gemot encubed  

Go Back   gemot encubed > Gemot > Technical Issues

Technical Issues For bug reports, problem solving, and help running Japanese software.

Reply
 
Thread Tools Display Modes
  #1  
Old 2007-01-02, 03:39
Roto
Guest
 
Posts: n/a
Default Proportionally-spaced text in ONScripter games

I've been a little bored towards the end of my winter vacation, which led me to re-read a few of the al|together novels. However, re-reading only held my attention so long and I started thinking about how a lot of these novels would look much more polished if they weren't limited to monospaced fonts. So, I grabbed the source code for ONScripter, fired up my text editor, and, well, you can probably see where this is going.

After a few hours I had several of the al|together localizations running with proportionally-spaced fonts. It's an experimental hack; I'm still in the process of familiarizing myself with ONScripter's code enough to be able to implement this cleanly and properly. But, it's working, and surprisingly well considering the fact that I hadn't taken a close look at ONScripter's code before tonight.

If you want to try it out, here's my patch, for insani's 2006/07/24 version of ONScripter. Add the -DPROP_TEXT flag to the appropriate Makefile.

And a few screenshots: 1 2

Hopefully this will be something I can keep working on in my free time.

Last edited by Roto; 2007-10-11 at 11:24.
Reply With Quote
  #2  
Old 2007-01-02, 06:43
Unregistered
Guest
 
Posts: n/a
Default

Disclaimer: I know almost nothing about ONScripter.

Do NScripter scripts have manual line breaks? Just, it looks like they wrap prematurely in your screenshots, which I'm guessing is because the breaks were already there, based on the previous font size.
If that's the case, I guess the next feature for you to add would be proper dynamic word-wrap :)

But the main thing I want to ask in this thread, since I've considered hacking on ONS in the past: why does Insani maintain a separate branch? Does the original ONS author not accept patches anymore?

Having a fork and not knowing which one to hack on discourages contributors...
Reply With Quote
  #3  
Old 2007-01-02, 09:25
Message's Avatar
Message Message is offline
Obsessive
 
Join Date: Dec 2003
Location: Netherlands
Posts: 323
Default

ONS already does linebreaking automatically, but it could be that the current algorithms presume a fixed-width font and thus cut off a line too early.

This looks great, Roto! I really hope this will make its way permanently into ONS at some point.
Reply With Quote
  #4  
Old 2007-01-03, 10:06
DaFool DaFool is offline
Regular
 
Join Date: Oct 2006
Posts: 97
Default

I've gotten used to the type-writery feel of ONS games, so much so that I try to emulate it in Ren'Py :)
Reply With Quote
  #5  
Old 2007-01-03, 20:54
ChocoEd ChocoEd is offline
Regular
 
Join Date: Dec 2004
Location: California, USA
Posts: 68
Default

Quote:
Originally Posted by Unregistered View Post
But the main thing I want to ask in this thread, since I've considered hacking on ONS in the past: why does Insani maintain a separate branch? Does the original ONS author not accept patches anymore?
Yeah, for a while insani was having difficulties getting patches accepted promptly, and stumbling over other cases where changes to the main codebase would break our previously-submitted patches haphazardly. Basically the needs of English-language ONScripter users and the needs of Japanese users weren't overlapping a whole lot.

I think the situation stabilized a bit later on, but basically the insani branch is just a consequence of our need to support our own releases reliably and on our own aggressive schedule... we're not really in the business of running an open-source collaborative project per se, so we haven't taken a lot of steps to streamline and encourage that side of things, unfortunately.
Reply With Quote
  #6  
Old 2007-01-04, 01:30
Unregistered
Guest
 
Posts: n/a
Default

I can understand the frustration of having your changes break. Even if there was an easy CVS/SVN repo where you had access it'd still be a pain to correct.

May I humbly suggest that rather than distribute full source code, you name an upstream version number and merely distribute a patch?
This way you can still maintain your patch separate without the hassle of merging with the latest version when you have other things to worry about, but people who want to take advantage of the latest official ONScripter codebase have an easier place to start from.

It's easier to try and apply an old patch to a newer codebase, than it is to diff two forks and merge them in my experience...

Feel free to ignore me. I've never *actually* worked on the code as of yet, other than trying to debug something a year or so ago, so I'm not in a position to start instructing people on how to maintain it really... :)
Reply With Quote
  #7  
Old 2007-01-06, 15:10
gp32 gp32 is offline
Irregular
 
Join Date: Dec 2004
Posts: 304
Default

Quote:
Originally Posted by Unregistered View Post
May I humbly suggest that rather than distribute full source code, you name an upstream version number and merely distribute a patch?
I would have done this a long time ago except for one thing: ogapee doesn't keep an archive of his versions; you only get access to his last few. As it stands, onscripter-insani has the largest extant archive of onscripter source code out there on the web today, because we *do* maintain access to every build we've ever done.

Furthermore, I've spoken to ogapee about this matter; he's told me several times that he prefers that I maintain a separate branch, as his concern for the English-speaking population isn't all that high (and my concern for the Japanese-speaking population isn't all that high either, so it was a natural fit).

As for the next version of onscripter, that won't be out for a while due to time constraints at IRL work. Maybe sometime late February ...
__________________
Quiet the sleep of the children who keep
Shadows clutched in the warmth of a dream
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may post new threads
You may post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Problem with editing Text in Overdrive Games Zeomak Technical Issues 9 2009-06-11 06:11
Extracting text from ONScripter Unregistered Technical Issues 4 2009-02-26 05:06
ONScripter text problems crazysjd89 Technical Issues 4 2008-02-29 10:40
ONScripter: single-byte text and variables delta Technical Issues 5 2007-02-28 07:57
Problems with Onscripter Games Guestmebbe? Technical Issues 2 2006-04-04 09:12


All times are GMT -8. The time now is 11:24.


Powered by vBulletin® Version 3.8.7
Copyright ©2000 - 2021, vBulletin Solutions, Inc.